-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] crm_salesperson_planner: Migration to 17.0 #585
Conversation
[UPD] Update crm_salesperson_planner.pot [UPD] README.rst
- Missing column renaming for not collapsing - Missing weekday conversion
61ce6e8
to
815e231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0bcfd6c
to
42daedb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently translated at 100.0% (196 of 196 strings) Translation: crm-16.0/crm-16.0-crm_salesperson_planner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/es/
Changes done: - Removed the (unnecessary) recurrence field from templates. - Recurrence fields (from calendar.event) are set as store=True. - Create an onchange to avoid inconsistent values by UX. - Modified the form view to make it more functional (similar to calendar.event). - Consider in _get_max_date() if a deadline (until) has been set. TT48238
… usable and with simplified code. TT48238
Currently translated at 100.0% (186 of 186 strings) Translation: crm-16.0/crm-16.0-crm_salesperson_planner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/es/
Currently translated at 100.0% (186 of 186 strings) Translation: crm-16.0/crm-16.0-crm_salesperson_planner Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/it/
42daedb
to
ccf6f8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat and works as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
ccf6f8f
to
0e43619
Compare
/ocabot migration crm_salesperson_planner |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at a48db4d. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 17.0
cc https://github.com/APSL 158506
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review
Issue #525